Fix arlo intilization when no base station available #16529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-needed
integration: arlo
small-pr
ghost
added
the
zellux
changed the title
|
CI has passed (https://travis-ci.org/home-assistant/home-assistant/builds/426783190) but status has not been updated on GitHub yet, is it a known issue? |
balloob
approved these changes
Sep 11, 2018
|
Awesome work! Will be included in Home Assistant 0.78 |
balloob
pushed a commit
that referenced
this pull request
Sep 11, 2018
* Fix arlo intilization when no base station * Fix pylint for empty camera check * Fix typo * Minor change to trigger CI again
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently arlo component always check if base station is included in PyArlo return object. However, in case user does not allow full control of base station, or only cameras are available, arlo initialization will fail. This diff should fix it.
Related issue (if applicable): #15026
Cases tested:
No camera or base station available.was shown in the log.