Update fan.zha platform. #16551
Merged
Update fan.zha platform. #16551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch from asyncio to async def() catch DeliveryError exceptions keep previous state, if reading 'fan_mode' attribute fails
homeassistant
added
cla-signed
platform: fan.zha
small-pr
ghost
added
the
pvizeli
reviewed
Sep 11, 2018
homeassistant/components/fan/zha.py
Outdated
| new_value = result.get('fan_mode', None) | ||
| self._state = VALUE_TO_SPEED.get(new_value, None) | ||
| self._state = VALUE_TO_SPEED.get(new_value, self._state) |
There was a problem hiding this comment.
The state is defined on core and need to be in that format. Please revert this change.
There was a problem hiding this comment.
you lost me here for a bit. self._state is defined by ZhaFan and pushed as a state. This code just keeps the previous state in case we fail to read the 'fan_mode' attribute. Although, from the other hand if we fail to get 'fan_mode' then the state should be None to represent the 'unknown'.
So is it better to keep old state or return None for failed updates?
if we fail to read 'fan_mode' attribute, use None for state
pvizeli
approved these changes
Sep 12, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
switch from asyncio to async def()
catch DeliveryError exceptions
keep previous state, if reading 'fan_mode' attribute fails
Checklist:
tox. Your PR cannot be merged unless tests pass