-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image support to hangouts notifications #16560
Conversation
Add image support to hangouts notification.
add image support
forgot schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead to try to validate the url use a schematic like other notify platforms like:
{
"photo": [
"file": "...",
"url": "...",
]
}
Or simple:
{
"image_file": "",
"image_url": "",
}
You can self select your style, but don't use this urlparse handling.
Examples:
- https://www.home-assistant.io/components/notify/
- https://www.home-assistant.io/components/notify.telegram/
After that it should be ready to merge.
* change to image_file/url
@pvizeli this ok ? |
We should create a helper in future |
So this PR added incorrect YAML to services.yaml which caused Home Assistant to not boot at all. Which begs the question, did anyone run this PR @quazzie ? |
Hmm :( sorry last commit (rename to image_file/_url) was made with github edit as i was away so no that last commit was not run. Stupid mistake, sorry. |
Description:
Adds image support to hangouts notification
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6254
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: