-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing python-websockets' version number #16578
Conversation
Hello @zoe1337, When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es). The commits that are missing a linked GitHub account are the following:
Unfortunately, we are unable to accept this pull request until this situation is corrected. Here are your options:
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community. Thanks, I look forward to checking this PR again soon! ❤️ |
Thanks! |
the homeassistant bot forgot to remove label:cla-error |
* increasing python-websockets' version number so now it works with python 3.7 * required version for websockets increased to work with Python 3.7 * script/gen_requirements_all.py is done
Description:
The webostv module has stopped working since the Python 3.6 -> 3.7 upgrade. Log showed an exception in the websockets module.
Dependency for websockets in the
REQUIREMENTS
variable has been updated. Websockets 3.2 (former version) doesn't run on Python 3.7, because it definesasync
which became a reserved keyword.Webostv module is working again.
Related issue (if applicable): n/a
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: no