Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config entry to iOS #16580

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Add config entry to iOS #16580

merged 2 commits into from
Sep 12, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 12, 2018

Description:

This makes iOS configurable via a config entry using the UI.

If users already have the iOS component configured, it will automatically create a config entry.

Would love for an iOS user to help test this.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner September 12, 2018 13:48
@ghost ghost assigned balloob Sep 12, 2018
@ghost ghost added the in progress label Sep 12, 2018
frenck
frenck approved these changes Sep 12, 2018
View reviewed changes
Copy link
Member

@frenck frenck left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a functional test on this branch using the latest beta version of the iOS app (1.2.0 (29)).

Worked like a charm. The app reports:

  • iOS Component Loaded ✔️
  • Device Tracker Component Loaded ✔️
  • iOS Notify Platform Loaded ✔️

Single click activation and working out of the box.

Also tested the case with an already configured ios component. The config entry was created.

@balloob balloob merged commit 3824582 into dev Sep 12, 2018
@ghost ghost removed the in progress label Sep 12, 2018
@balloob balloob deleted the ios-config-entry branch September 12, 2018 18:17
@balloob balloob mentioned this pull request Sep 28, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees

@balloob balloob

Labels
cla-signed core integration: ios integration: notify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balloob @frenck @homeassistant