Met.no weather platform #16582
Merged
Met.no weather platform #16582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Sep 13, 2018
| continue | ||
|
|
||
| if param == 'precipitation': | ||
| new_state = loc_data[param]['@value'] |
There was a problem hiding this comment.
We should extract this into a third party lib.
houndci-bot
reviewed
Sep 15, 2018
| self._pressure = metno.get_forecast('pressure', ordered_entries) | ||
| self._humidity = metno.get_forecast('humidity', ordered_entries) | ||
| self._wind_speed = metno.get_forecast('windSpeed', ordered_entries) | ||
| self._wind_bearing = metno.get_forecast('windDirection', ordered_entries) |
There was a problem hiding this comment.
line too long (81 > 79 characters)
| self._weather_data = metno.MetWeatherData(coordinates, | ||
| clientsession, | ||
| 'https://aa015h6buqvih86i1.api.met.no/' | ||
| 'weatherapi/locationforecast/1.9/' |
There was a problem hiding this comment.
line too long (84 > 79 characters)
| self._urlparams = coordinates | ||
| self._weather_data = metno.MetWeatherData(coordinates, | ||
| clientsession, | ||
| 'https://aa015h6buqvih86i1.api.met.no/' |
There was a problem hiding this comment.
line too long (89 > 79 characters)
| 'msl': str(elevation), | ||
| } | ||
|
|
||
| async_add_entities([MetWeather(name, coordinates, async_get_clientsession(hass))]) |
There was a problem hiding this comment.
line too long (86 > 79 characters)
|
Still need to test it more locally |
added 2 commits
September 15, 2018 15:08
2 tasks
| """Initialise the platform with a data instance and site.""" | ||
| import metno | ||
| self._name = name | ||
| self._urlparams = coordinates |
| """Start unavailability tracking.""" | ||
| await self._fetching_data() | ||
|
|
||
| async def _fetching_data(self, *_): |
|
@Danielhiversen merge when you're happy with testing. 👍 |
houndci-bot
reviewed
Sep 20, 2018
| async def async_added_to_hass(self): | ||
| """Start fetching data.""" | ||
| await self._fetch_data() | ||
| async_track_utc_time_change(self.hass, self._update, minute=31, second=0) |
There was a problem hiding this comment.
line too long (81 > 79 characters)
| https://home-assistant.io/components/weather.met/ | ||
| """ | ||
| import logging | ||
| from datetime import timedelta |
There was a problem hiding this comment.
'datetime.timedelta' imported but unused
MartinHjelmare
approved these changes
Sep 20, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A weather component with data from Met.no
This is the same data source as the yr.no sensor.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6287
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.