Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocket list APIs for the registries #16597

Merged
merged 4 commits into from
Sep 14, 2018
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 13, 2018

Description:

This adds two APIs: one to list the device registry entries, one to list the entity registry entries.

Meant to power a frontend for devices 馃憤

CC @Kane610

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

msg['id'], [{
'config_entries': list(entry.config_entries),
'connections': list(entry.connections),
'identifiers': list(entry.identifiers),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are connections and identifiers really relevant to expose to the Gui? Config entries I can understand to tie be able to tie them together in some hierarchy but the others are mostly internal usage.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, little too eager!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually connections could be beneficial? you can see mac address etc ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to expose connections and identifiers we need to up our game and standardise what can be a part of them. Right now it is not concrete enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if we do expose connections we can just as well keep identifiers as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know too much about this part of Hass, but it looks ok to me!

@balloob balloob merged commit 05c0717 into dev Sep 14, 2018
@ghost ghost removed the in progress label Sep 14, 2018
@balloob balloob deleted the websocket-api-registries branch September 14, 2018 09:57
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants