-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add websocket list APIs for the registries #16597
Conversation
msg['id'], [{ | ||
'config_entries': list(entry.config_entries), | ||
'connections': list(entry.connections), | ||
'identifiers': list(entry.identifiers), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are connections and identifiers really relevant to expose to the Gui? Config entries I can understand to tie be able to tie them together in some hierarchy but the others are mostly internal usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, little too eager!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually connections could be beneficial? you can see mac address etc ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to expose connections and identifiers we need to up our game and standardise what can be a part of them. Right now it is not concrete enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well if we do expose connections we can just as well keep identifiers as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha.
Look, connections is actually standardized to an extend:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know too much about this part of Hass, but it looks ok to me!
Description:
This adds two APIs: one to list the device registry entries, one to list the entity registry entries.
Meant to power a frontend for devices 馃憤
CC @Kane610
Checklist:
tox
. Your PR cannot be merged unless tests passIf the code does not interact with devices: