Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new devices to HomematicIP Cloud #16636

Merged
merged 3 commits into from
Sep 15, 2018
Merged

Add new devices to HomematicIP Cloud #16636

merged 3 commits into from
Sep 15, 2018

Conversation

worm-ee
Copy link
Contributor

@worm-ee worm-ee commented Sep 15, 2018

Description:

Add HomematicIP Cloud support for:

  • Outdoor temperature sensor
  • Water sensor
  • Rotary handle sensor

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6290

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost added the in progress label Sep 15, 2018
@worm-ee worm-ee changed the title [WIP] Add new devices to HomematicIP Cloud Add new devices to HomematicIP Cloud Sep 15, 2018


class HomematicipWaterDetector(HomematicipGenericDevice, BinarySensorDevice):
"""Representation of a HomematicIP Cloud water detector detector."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be two "detector"?

@MartinHjelmare MartinHjelmare merged commit 05922ac into home-assistant:dev Sep 15, 2018
@ghost ghost removed the in progress label Sep 15, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
@worm-ee worm-ee deleted the add-homematicip_cloud-new-devices branch October 7, 2018 08:04
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants