Fix Ecovacs vacuums showing "None" for name #16654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was previously checking for a missing key, when should have been checking for the value being None
homeassistant
added
cla-signed
integration: ecovacs
platform: vacuum.ecovacs
small-pr
ghost
assigned 
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some users had their vacuums set to the name "None" which was an error. Now it'll be set to the device ID.
Was previously checking for a missing key, when should have been checking for the value being None
Related issue (if applicable): fixes #16584 (at least part of it)
Pull request in home-assistant.github.io with documentation (if applicable): none
Checklist:
tox. Your PR cannot be merged unless tests pass