Config flow tradfri #16665
Merged
Config flow tradfri #16665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned | info[CONF_HOST] = host | ||
| info[CONF_IMPORT_GROUPS] = conf[CONF_ALLOW_TRADFRI_GROUPS] | ||
|
|
||
| hass.async_add_job(hass.config_entries.flow.async_init( |
There was a problem hiding this comment.
Use hass.async_create_task.
| if conf is None: | ||
| return True | ||
|
|
||
| known_hosts = await hass.async_add_job(load_json, |
There was a problem hiding this comment.
Use hass.async_add_executor_job.
| if host is None or host in known_hosts: | ||
| return True | ||
|
|
||
| hass.async_add_job(hass.config_entries.flow.async_init( |
| gateways = hass.data.setdefault(KEY_GATEWAY, {}) | ||
| hass.data.setdefault(KEY_API, {})[entry.entry_id] = api | ||
|
|
||
| hass.data.setdefault(KEY_TRADFRI_GROUPS, {}) |
There was a problem hiding this comment.
This doesn't seem to be used anymore.
| hass.async_create_task(hass.config_entries.async_forward_entry_setup( | ||
| entry, 'light' | ||
| )) | ||
| # hass.async_create_task(hass.config_entries.async_forward_entry_setup( |
There was a problem hiding this comment.
Remove comment before merge.
| with async_timeout.timeout(5): | ||
| key = await api_factory.generate_psk(security_code) | ||
| except RequestError as err: | ||
| print(err) |
| return await self._entry_from_data(auth) | ||
|
|
||
| except AuthError as err: | ||
| errors['base'] = err.code |
There was a problem hiding this comment.
If it's the key that is wrong we could use a specific error key to mark the form for the user.
|
Can you remove the group feature? They don't work like it should. User need use the light group or they will be not happy |
|
Should remove all translation json modification from PR |
balloob
force-pushed
the
config-flow-tradfri
branch
from
f8507c1
to
d4d8bf3
Compare
houndci-bot
reviewed
Sep 19, 2018
|
|
||
| assert len(mock_gateway_info.mock_calls) == 1 | ||
| assert len(mock_entry_setup.mock_calls) == 1 | ||
|
|
houndci-bot
reviewed
Sep 19, 2018
| @@ -10,6 +10,8 @@ | |||
| from homeassistant.components import tradfri | |||
| from homeassistant.setup import async_setup_component | |||
|
|
|||
| from tests.common import MockConfigEntry, mock_coro | |||
There was a problem hiding this comment.
'tests.common.mock_coro' imported but unused
pvizeli
approved these changes
Sep 19, 2018
pvizeli
approved these changes
Sep 19, 2018
|
|
||
| @pytest.fixture | ||
| def mock_auth(): | ||
| """Mock get_gateway_info.""" |
|
|
||
|
|
||
| async def test_import_connection(hass, mock_gateway_info, mock_entry_setup): | ||
| """Test a connection via discovery.""" |
| return await self.async_step_auth() | ||
|
|
||
| async def async_step_auth(self, user_input=None): | ||
| """Handle a flow initialized by the user.""" |
MartinHjelmare
approved these changes
Sep 19, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a config flow to IKEA Tradfri.
Imports old config files.
Works with discovery.
Will allow us to hook into the device registry soon 馃槑
WIP: still have to update the tests.
CC @lwis @ggravlingen
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: