MyQ Open State Fix

[geekofweek]

Fixes issues with MyQ reporting an open state

Description:

This resolves an issue with the last change to represent discrete status of the door position caused an issue with it reporting the door status as open. This is a break fix as any automation relying on the state of the cover to be open would fail.

Related issue (if applicable): fixes #16680 (and potentially #16783)

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

NA

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[houndci-bot]

line too long (85 > 79 characters)

[geekofweek]

Fix line too long

[balloob]

That's weird that that one was missing

[talljohnson]

I had the same error as others with STATE_OPENING while I was using 0.79.2.
Last fix in 0.79.3 resolved issue with the addition of STATE_OPEN. Simple fix.

UPDATE:

I responded too soon. After a few minutes, I get the same error still.

2018-10-05 17:22:10 ERROR (SyncWorker_1) [pymyq] MyQ - API Error[get_devices] 500 Server Error: Internal Server Error for url: https://myqexternal.myqdevice.com/api/v4/UserDeviceDetails/Get
2018-10-05 17:22:10 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 234, in async_update_ha_state
    state = self.state
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/cover/__init__.py", line 231, in state
    if self.is_opening:
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/cover/myq.py", line 109, in is_opening
    return MYQ_TO_HASS[self._status] == STATE_OPENING
KeyError: False

[geekofweek]

@talljohnson slightly different problem, MyQ is now sending back a new state and giving 500 server errors on occasion.

See this issue:
#16885

[talljohnson]

@geekofweek thanks for the clarification. Switching threads.