Save disabled_by in entity registry #16699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
amelchio
reviewed
Sep 18, 2018
| @@ -240,6 +240,7 @@ def _data_to_save(self): | |||
| 'unique_id': entry.unique_id, | |||
| 'platform': entry.platform, | |||
| 'name': entry.name, | |||
| 'disabled_by': entry.disabled_by | |||
There was a problem hiding this comment.
Maybe add a trailing comma so the next addition can also be a single-line diff.
|
Can you update the test to make sure we don't forget about it again |
|
Merging it without the test because I don't want to have disabled_by added to |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The entity registry supports a
disabled_byfield to exclude entities from being processed. When the entity_registry is automatically generated/updated by HA, thedisabled_byfield was not included and would be stripped out.Related issue (if applicable): fixes #13643
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):N/A
Checklist:
tox. Your PR cannot be merged unless tests pass