Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade youtube dl #16729

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Upgrade youtube dl #16729

merged 1 commit into from
Sep 20, 2018

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Sep 20, 2018

Description

Changelog: https://github.com/rg3/youtube-dl/blob/master/ChangeLog

Tested with the following configuration:

media_extractor:

Service call:

{  
   "entity_id":"media_player.mpd",
   "media_content_id":"https://www.youtube.com/watch?v=PA_m-ppThPM",
   "media_content_type":"music"
}

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@Danielhiversen Danielhiversen merged commit dfe38b4 into dev Sep 20, 2018
@Danielhiversen Danielhiversen deleted the upgrade-youtube_dl branch September 20, 2018 07:37
@ghost ghost removed the in progress label Sep 20, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
@fabaff fabaff restored the upgrade-youtube_dl branch October 2, 2018 18:53
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants