Extract lovelace to it's own component #16816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
houndci-bot
reviewed
Sep 24, 2018
| ) | ||
| except FileNotFoundError: | ||
| error = ('file_not_found', | ||
| 'Could not find ui-lovelace.yaml in your config dir.') |
There was a problem hiding this comment.
continuation line over-indented for visual indent
| """Send lovelace UI config over websocket config.""" | ||
| error = None | ||
| try: | ||
| config = await hass.async_add_job( |
There was a problem hiding this comment.
Use async_add_executor_job.
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This moves Lovelace from frontend component to it's own. Changes websocket command but made backwards compatible to avoid frontend update issues.
Example entry for
configuration.yaml(if applicable):frontend:Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: