Fail if dirty #16839
Merged
Fail if dirty #16839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
pvizeli
approved these changes
Sep 25, 2018
2 tasks
balloob
force-pushed
the
fail-if-dirty
branch
from
35b5050
to
eb58d54
Compare
pvizeli
reviewed
Sep 25, 2018
script/check_dirty
Outdated
| @@ -0,0 +1,2 @@ | |||
| #!/bin/bash | |||
| [[ -z $(git ls-files --others --exclude-standard) ]] || { echo; echo '***** ERROR: Tests are leaving files behind. Please update the tests to avoid writing any files.'; echo; exit 1; } | |||
There was a problem hiding this comment.
{ echo -e "\n****...\n"; exit 1 };
balloob
force-pushed
the
fail-if-dirty
branch
from
5d92669
to
7bb1e67
Compare
Merged
balloob
force-pushed
the
fail-if-dirty
branch
from
0dc5233
to
fef360a
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fail the tests if there are untracked files in the git repo after the tests ran.
This means that some tests don't mock I/O correctly.
This test will fail now, and once I finish catching all the offenders, I'll rebase and it will pass 馃憤
Checklist:
tox. Your PR cannot be merged unless tests pass