Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support old tradfri config format #16841

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Support old tradfri config format #16841

merged 1 commit into from
Sep 25, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 25, 2018

Description:

Old Tradfri format had a fixed identitiy of 'homeassistant'. This adds support for it.

Related issue (if applicable): Reported by @cgtobi via Discord

Error doing job: Task exception was never retrieved

Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/data_entry_flow.py", line 64, in async_init
    return await self._async_handle_step(flow, flow.init_step, data)
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/data_entry_flow.py", line 98, in _async_handle_step
    result = await getattr(flow, method)(user_input)  # type: Dict
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/tradfri/config_flow.py", line 98, in async_step_import
    self.hass, user_input['host'], user_input['identity'],
KeyError: 'identity'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.79 milestone Sep 25, 2018
@ghost ghost assigned balloob Sep 25, 2018
@ghost ghost added the in progress label Sep 25, 2018
@pvizeli pvizeli merged commit 2b2502c into dev Sep 25, 2018
@ghost ghost removed the in progress label Sep 25, 2018
@pvizeli pvizeli deleted the fix-old-tradfri branch September 25, 2018 09:57
balloob added a commit that referenced this pull request Sep 25, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants