Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HA native OAuth2 flow for google assistant components #16848

Merged
merged 4 commits into from
Sep 26, 2018

Conversation

awarecan
Copy link
Contributor

@awarecan awarecan commented Sep 25, 2018

Description:

Use HA native OAuth2 flow for google assistant components

Google Account Link settings:
image

Advantage
Simplify configuration
Leverage HA user system, different google user can map to different HA user.

Breaking Changes

Need change google account link flow, need re-link account
Need remove client_id, access_token, and agent_user_id from configuration.yaml

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6357

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob
Copy link
Member

balloob commented Sep 25, 2018

image

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I think that for client ID, we should add a new page https://www.home-assistant.io/google_assistant/ which can be used as client ID and that whitelists the redirect URI. We did a similar thing for iOS: https://github.com/home-assistant/home-assistant.io/blob/next/source/ios/index.markdown (look at raw version)

Pending docs this looks good to go!

@awarecan
Copy link
Contributor Author

I don't think we need https://www.home-assistant.io/google_assistant/ redirect URI support. Yes it may looks little better for user experience, but it adds unnecessary dependency between Google Assistant feature and document website.

@balloob balloob merged commit 92a5068 into home-assistant:dev Sep 26, 2018
@ghost ghost removed the in progress label Sep 26, 2018
@awarecan awarecan deleted the google-assistant-oauth branch September 27, 2018 16:38
@balloob balloob mentioned this pull request Oct 12, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants