Fix fan_init test #16865
Merged
Fix fan_init test #16865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
All folders need to have a |
|
I looked through the documentation. It isn't necessary for discovery, just to prevent name collisions. Noticed that Edit: This is true for py3.3 and above. See note block: https://docs.pytest.org/en/latest/goodpractices.html#tests-as-part-of-application-code |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Renamed
tests/components/fan/__init__.pytofan/test_init.py, since it includes a test for the base FanEntity. Also updated it to conform with the current fan model.Checklist:
tox. Your PR cannot be merged unless tests pass