Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ring camera setup sync #16866

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Make ring camera setup sync #16866

merged 1 commit into from
Sep 26, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 25, 2018

Description:

It's doing I/O

Related to #4210

CC @arsaboo

@ghost ghost assigned balloob Sep 25, 2018
@ghost ghost added the in progress label Sep 25, 2018
@balloob balloob added this to the 0.79 milestone Sep 25, 2018
@arsaboo
Copy link
Contributor

arsaboo commented Sep 25, 2018

This PR definitely helped. Now, I am only seeing one warning

2018-09-25 12:44:34 WARNING (MainThread) [homeassistant.components.sensor] Setup of platform ring is taking over 10 seconds.

@awarecan suggested that it is related to the sensor, which also needs some love. Leaving it here so that we don't miss out.

@balloob balloob merged commit ba2b851 into dev Sep 26, 2018
@ghost ghost removed the in progress label Sep 26, 2018
@balloob balloob deleted the fix-ring-camera-async branch September 26, 2018 06:52
balloob added a commit that referenced this pull request Sep 26, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants