Rachio component modernization #16911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `unique_id` to all rachio entities Add platform discovery to rachio component Move config options from switch.rachio platform to the rachio component
ghost
assigned 
pvizeli
reviewed
Sep 27, 2018
|
|
||
| # Load platforms | ||
| for component in SUPPORTED_DOMAINS: | ||
| discovery.load_platform(hass, component, DOMAIN, {}, config) |
There was a problem hiding this comment.
You can push the time config with {} to platform without need store it to hass.data the hole runtime.
There was a problem hiding this comment.
I was trying to figure out how that works! Thanks for the hint; I'll fix this.
There was a problem hiding this comment.
I think that it's nicer to have it all in 1 location, which is the person. That is also how it is going to be done when you migrate to config entries.
balloob
reviewed
Sep 27, 2018
| @@ -13,7 +13,7 @@ | |||
| from homeassistant.auth.util import generate_secret | |||
| from homeassistant.components.http import HomeAssistantView | |||
| from homeassistant.const import CONF_API_KEY, EVENT_HOMEASSISTANT_STOP, URL_API | |||
| import homeassistant.helpers.config_validation as cv | |||
| from homeassistant.helpers import discovery, config_validation as cv | |||
There was a problem hiding this comment.
Oh man discovery, all the cool kids are already using config entries!
There was a problem hiding this comment.
That's the next step! Minimal features per PR!
(really I just needed unique_id here, and fixed this while I had it open)
balloob
approved these changes
Sep 27, 2018
2 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some modernization to the Rachio component:
unique_idto all rachio entitiesRelated issue (if applicable): fixes n/a
Pull request in home-assistant.io with documentation (if applicable): pending
Breaking Change
The Rachio component no longer requires you to specify
switchandbinary_sensorplatforms. These platforms will be initialized automatically by the Rachio component. For the end user, this means:switchandbinary_sensorentries withplatform: rachiomanual_run_minson theswitchplatform, move that parameter to therachio:component configuration.Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.