Handle exception handling websocket command #16927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: websocket_api
small-pr
ghost
assigned 
balloob
added a commit
that referenced
this pull request
Sep 27, 2018
* Handle exception handling websocket command * lint * Lint2
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Handle when a websocket message handler is throwing an exception. Before this we would just close the connection, leading to some weird situations where frontend tries to reconnect right away -> bam close again.
Related issue (if applicable): @robbiet480 in chat
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: