Add basic support for Tradfri switches #17007
Conversation
ghost
added
the
|
|
|
|
ggravlingen
changed the title
| _LOGGER = logging.getLogger(__name__) | ||
|
|
||
| DEPENDENCIES = ['tradfri'] | ||
| PLATFORM_SCHEMA = SWITCH_PLATFORM_SCHEMA |
| def __init__(self, switch, api, gateway_id): | ||
| """Initialize a switch.""" | ||
| self._api = api | ||
| self._unique_id = "switch-{}-{}".format(gateway_id, switch.id) |
There was a problem hiding this comment.
"switch" isn't needed. The core will keep track of platform and domain.
| cmd = self._switch.observe(callback=self._observe_update, | ||
| err_callback=self._async_start_observe, | ||
| duration=0) | ||
| self.hass.async_add_job(self._api(cmd)) |
There was a problem hiding this comment.
Use hass.async_create_task.
| import logging | ||
|
|
||
| from homeassistant.core import callback | ||
| from homeassistant.components.switch import ( |
There was a problem hiding this comment.
'homeassistant.components.switch.PLATFORM_SCHEMA' imported but unused
|
Tox passes the unit tests and lint, but return errors when installing deps for pylint and typing. Given that TravisCI passes, this should be ok anyways? |
|
|
||
|
|
||
| async def async_setup_entry(hass, config_entry, async_add_entities): | ||
| """Load Tradfri switchs based on a config entry.""" |
| @callback | ||
| def _async_start_observe(self, exc=None): | ||
| """Start observation of switch.""" | ||
| # pylint: disable=import-error |
There was a problem hiding this comment.
Why do we need to disable this?
There was a problem hiding this comment.
I must admin I borrowed a lot of the code from the Trådfri light-component and this line is in there. That aside, won't lint throw an error when you do an import that's not at the top of a module?
There was a problem hiding this comment.
No, we import here since we import something from the requirements library. Try remove the disable.
There was a problem hiding this comment.
Looks like it worked without the line.
|
I looked into the tests folder earlier today and it looks like the tests are all not really relating to what the component does, merely how it's setup within Home Assistant. What are the general guidelines here? |
|
We have excluded these modules from coverage so tests are not required except for config flow. I think it's ok to not add tests for this platform. |
Description:
IKEA has released new wall switches. Support was added to pytradfri in 5.6.0 and the purpose of this PR is to add support to Home Assistant.
Related issue (if applicable): fixes #
Fixes #16608
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6392
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: