Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hue discovery on manual configuration #17070

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Oct 2, 2018

Description:

We used to allow hue: to be configured in configuration.yaml without any options. This would then trigger a discovery of hubs and then set them up. When we moved to config entries, the logic changed to discover and them import them. This allowed people transitioning to import their auth.

This logic was introduced on March 30. Now it's time to sunset this behavior.

Related issue (if applicable): fixes #17025

Example entry for configuration.yaml (if applicable):

hue:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned balloob Oct 2, 2018
@ghost ghost added the in progress label Oct 2, 2018
@balloob balloob changed the title Remove discovery Remove Hue discovery on manual configuration Oct 2, 2018
Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All PRs they remove more code as new is a good PR :D

@pvizeli pvizeli merged commit 769dda7 into dev Oct 4, 2018
@pvizeli pvizeli deleted the hue-remove-discovery branch October 4, 2018 14:04
@ghost ghost removed the in progress label Oct 4, 2018
@balloob balloob mentioned this pull request Oct 12, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hue: component init will fail if internet unavailable.
5 participants