verisure configurable polling #17144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: verisure
small-pr
ghost
assigned 
persandstrom
added a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Oct 4, 2018
documentation for home-assistant/core#17144
2 tasks
| @@ -53,6 +54,8 @@ | |||
| vol.Optional(CONF_SMARTPLUGS, default=True): cv.boolean, | |||
| vol.Optional(CONF_THERMOMETERS, default=True): cv.boolean, | |||
| vol.Optional(CONF_SMARTCAM, default=True): cv.boolean, | |||
| vol.Optional(CONF_POLLING_RATE, default=1): vol.All( | |||
| vol.Coerce(int), vol.Range(min=1)), | |||
There was a problem hiding this comment.
We usually use cv.time_period.
There was a problem hiding this comment.
That would allow the user to set seconds, right? Verisure seems to lock people out that poll too often so I rather see that a minute is minimum.
There was a problem hiding this comment.
We can set a minimum time too.
| @@ -53,6 +54,8 @@ | |||
| vol.Optional(CONF_SMARTPLUGS, default=True): cv.boolean, | |||
| vol.Optional(CONF_THERMOMETERS, default=True): cv.boolean, | |||
| vol.Optional(CONF_SMARTCAM, default=True): cv.boolean, | |||
| vol.Optional(CONF_POLLING_RATE, default=1): vol.All( | |||
There was a problem hiding this comment.
Normally we call this CONF_SCAN_INTERVAL.
There was a problem hiding this comment.
Ok. I should change that. When is the next release?
There was a problem hiding this comment.
Great., I will be able to update during the weekend. Thanks @MartinHjelmare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some users have received mail from Verisure informing them to poll less.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If
[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14
[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54