Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix switch flux - light service call #17187

Merged
merged 2 commits into from
Oct 6, 2018
Merged

Bugfix switch flux - light service call #17187

merged 2 commits into from
Oct 6, 2018

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 6, 2018

Description:

Fixes bug introduced with #16917, that occurred if one of service_data variables is None. Previously this was checked by the now removed light.turn_on.

Related issue (if applicable): fixes #17183

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@cdce8p cdce8p added this to the 0.80 milestone Oct 6, 2018
@ghost ghost assigned cdce8p Oct 6, 2018
@ghost ghost added the in progress label Oct 6, 2018
@amelchio amelchio merged commit 5d6562a into home-assistant:dev Oct 6, 2018
@ghost ghost removed the in progress label Oct 6, 2018
@cdce8p cdce8p deleted the bugfix-switch-flux branch October 6, 2018 21:58
balloob pushed a commit that referenced this pull request Oct 8, 2018
* Bugfix switch flux - light service call

* Change x_val and y_val test
@balloob balloob mentioned this pull request Oct 12, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.80.0b1 Switch.Flux Broken (w/disable_brightness_adjust )
4 participants