Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verisure standard config for scan interval #17192

Merged
merged 2 commits into from
Oct 6, 2018
Merged

Verisure standard config for scan interval #17192

merged 2 commits into from
Oct 6, 2018

Conversation

persandstrom
Copy link
Contributor

@persandstrom persandstrom commented Oct 6, 2018 •
edited

Description:

Use standard configuration parameter names and types.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

verisure:                                                                        
  username: ****
  password: ****
  scan_interval: 00:30:00

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

@ghost ghost assigned persandstrom Oct 6, 2018
@ghost ghost added the in progress label Oct 6, 2018
MartinHjelmare
MartinHjelmare approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinHjelmare MartinHjelmare added this to the 0.80 milestone Oct 6, 2018
@MartinHjelmare
Copy link
Member

Can be merged when build passes and docs PR is linked.

@persandstrom
Copy link
Contributor Author

documentation PR: home-assistant/home-assistant.io#6558

@persandstrom persandstrom mentioned this pull request Oct 6, 2018
Merged
2 tasks
@MartinHjelmare MartinHjelmare changed the title Verisure standard config for Verisure standard config for scan interval Oct 6, 2018
@MartinHjelmare MartinHjelmare merged commit 760047f into home-assistant:dev Oct 6, 2018
@ghost ghost removed the in progress label Oct 6, 2018
balloob pushed a commit that referenced this pull request Oct 8, 2018
@persandstrom @balloob
Verisure standard config for scan interval (#17192)
7369af0 
* verisure configurable polling

* fix indentation
@balloob balloob mentioned this pull request Oct 12, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@persandstrom persandstrom

Labels
cherry-picked cla-signed integration: verisure small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.80
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@persandstrom @MartinHjelmare @frenck @balloob @homeassistant