Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tradfri groups for new imported entries #17310

Merged
merged 6 commits into from
Oct 11, 2018
Merged

Allow tradfri groups for new imported entries #17310

merged 6 commits into from
Oct 11, 2018

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Oct 10, 2018 •
edited

Description:

  • Allow import groups via new config yaml setup.
  • Fix and add tests.
  • Clean up old config schema option.

Related issue (if applicable):
fixes #16992

Pull request in home-assistant.io with documentation (if applicable):
home-assistant/home-assistant.io#6664

Example entry for configuration.yaml (if applicable):

tradfri:
  host: REDACTED
  allow_tradfri_groups: true

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@ghost ghost assigned MartinHjelmare Oct 10, 2018
@ghost ghost added the in progress label Oct 10, 2018
@MartinHjelmare MartinHjelmare force-pushed the allow-tradfri-groups-new-imported-entries branch from c1a2364 to d412aea Compare October 10, 2018 13:21
balloob
balloob approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge when one comment has been addressed

@MartinHjelmare MartinHjelmare mentioned this pull request Oct 10, 2018
Merged
2 tasks
@balloob balloob added this to the 0.80 milestone Oct 11, 2018
@balloob balloob merged commit 58af332 into home-assistant:dev Oct 11, 2018
@ghost ghost removed the in progress label Oct 11, 2018
@MartinHjelmare MartinHjelmare deleted the allow-tradfri-groups-new-imported-entries branch October 11, 2018 09:20
balloob pushed a commit that referenced this pull request Oct 12, 2018
@MartinHjelmare @balloob
Allow tradfri groups for new imported entries (#17310)
8778b70 
* Clean up leftover config schema option

* Allow import groups via new config yaml setup

* Fix and add test

* Add a test without groups for legacy import

* Change default import groups to False

* Fix I/O in test
@balloob balloob mentioned this pull request Oct 12, 2018
Merged
@MartinHjelmare MartinHjelmare mentioned this pull request Jan 3, 2019
Closed
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees

@MartinHjelmare MartinHjelmare

Labels
cherry-picked cla-signed Hacktoberfest integration: tradfri
Projects
None yet
Milestone
0.80
Development

Successfully merging this pull request may close these issues.

Tradfri groups disapeared in 0.79
3 participants
@MartinHjelmare @balloob @homeassistant