Remove day as a config option in speedtest sensor #17452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: sensor.speedtest
small-pr
ghost
added
the
2 tasks
|
This is a breaking change |
amelchio
approved these changes
Oct 14, 2018
|
@amelchio like that? |
kennedyshead
changed the title
amelchio
changed the title
|
Ty ;) |
|
Like that :) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This removes the day configuration.
Breaking change: The configuration option
dayhas been removed from thespeedtestsensor.Related issue (if applicable): fixes #17352
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6807
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: