HomeKit: Ignore Garage state command if target state is current state

[adrum]

Description:

I have a HomeKit automation that makes sure my garage is closed at a certain time. If the garage was already closed, it would improperly call the service then set the state as closing. Home Assistant would safely ignore the service call, but HomeKit would show the wrong state (closing). This code adds a check to ensure the the target state is different than the current state before issuing a service call and changing the state.

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass

[homeassistant]

Hi @adrum,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[balloob]

We shouldn't do this as we don't know if the state that we have internally is correct, and so might ignore a perfectly fine call.

[cdce8p]

I could reproduce the error you've been describing @adrum.
I do think this should be implemented, but I would prefer it to be in HAP-python.

A bit of background (also for @balloob) why I think so

HomeKit is designed to only publish state changes that result in a new state. E.g. it doesn't call open on an open cover/garaged door. That's true for HomeKit scenes as well, but I wasn't aware that automations don't seem to respect that. I'm not sure it's that way by design (maybe a bug?).

Why do I think this should be in HAP-python?

If that's a problem that exists with automations, it's not just limited to garage doors. Additionally implementing it upstream will reduce complexity, since we don't have to add checks to every setter.