New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opentherm_gw binary sensor support #17625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the binary_sensor entity be non polling?
Should be non-polling indeed. Thanks for noticing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the other platforms implemented as non polling?
After your comment I checked the climate and sensor platforms as well to make sure, they are both non-polling. Don't know how I missed it here... |
Good! Can be merged when build passes. |
Awesome! I was already hoping to get this through for 0.81. Thanks for reviewing! |
Description:
Add binary sensor support to the OpenTherm Gateway component
Related issue (if applicable): ref. #16670
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6975
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.