Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opentherm_gw binary sensor support #17625

Merged
merged 2 commits into from Oct 20, 2018

Conversation

mvn23
Copy link
Contributor

@mvn23 mvn23 commented Oct 19, 2018

Description:

Add binary sensor support to the OpenTherm Gateway component

Related issue (if applicable): ref. #16670

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6975

Example entry for configuration.yaml (if applicable):

opentherm_gw:
  device: /dev/ttyUSB0
  monitored_variables:
  - flame_on
  - slave_ch_active
  - slave_service_required
  - slave_water_overtemp
  - otgw_gpio_a_state

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost added the in progress label Oct 19, 2018
@mvn23 mvn23 changed the title Add OpenTherm Gateway binary sensor support. Add opentherm_gw binary sensor support Oct 20, 2018
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the binary_sensor entity be non polling?

homeassistant/components/opentherm_gw.py Show resolved Hide resolved
@mvn23
Copy link
Contributor Author

mvn23 commented Oct 20, 2018

Should be non-polling indeed. Thanks for noticing!

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the other platforms implemented as non polling?

@mvn23
Copy link
Contributor Author

mvn23 commented Oct 20, 2018

After your comment I checked the climate and sensor platforms as well to make sure, they are both non-polling. Don't know how I missed it here...

@MartinHjelmare
Copy link
Member

Good! Can be merged when build passes.

@mvn23
Copy link
Contributor Author

mvn23 commented Oct 20, 2018

Awesome! I was already hoping to get this through for 0.81. Thanks for reviewing!

@MartinHjelmare MartinHjelmare merged commit 237ac08 into home-assistant:dev Oct 20, 2018
@ghost ghost removed the in progress label Oct 20, 2018
@mvn23 mvn23 deleted the opentherm_gw branch October 24, 2018 12:57
@balloob balloob mentioned this pull request Oct 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants