Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor all sensor types by default to rtorrent #17894

Merged
merged 4 commits into from
Oct 28, 2018
Merged

Conversation

riptl
Copy link
Contributor

@riptl riptl commented Oct 27, 2018

Description:

After merging #17421, @MartinHjelmare commented:

I just realised that this shouldn't have an empty list as default if this config option is optional. Either have it be optional and default to all conditions, or make it required and remove default.

This PR adds all three sensor types to monitored_variables, if the user omits the field in the configuration.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@riptl riptl mentioned this pull request Oct 27, 2018
7 tasks
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@MartinHjelmare
Copy link
Member

Can be merged when build passes.

Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@fabaff fabaff changed the title rtorrent.py: Monitor all sensor types by default Monitor all sensor types by default to rtorrent Oct 28, 2018
@riptl
Copy link
Contributor Author

riptl commented Oct 28, 2018

Travis CI builds are stuck again :/

@MartinHjelmare
Copy link
Member

I cancelled and restarted.

@riptl
Copy link
Contributor Author

riptl commented Oct 28, 2018

Thanks, but it still seems to be stuck on Created 🤔
Let's just wait it out.

@fabaff fabaff merged commit b62b3b2 into home-assistant:dev Oct 28, 2018
@ghost ghost removed the in progress label Oct 28, 2018
@balloob balloob mentioned this pull request Nov 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants