Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry functionality failing of Unifi #17927

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Oct 28, 2018

Description:

Fix controller not being stored when setup fails and sequentially fails the retry functionality

Same fix as #17877, but fixes tests as well.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@ghost ghost assigned Kane610 Oct 28, 2018
@ghost ghost added the in progress label Oct 28, 2018
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@fabaff fabaff changed the title UniFi - Fix retry functionality failing Fix retry functionality failing of Unifi Oct 28, 2018
@Kane610
Copy link
Member Author

Kane610 commented Oct 29, 2018

@balloob this one would be good to get into .2

@balloob balloob added this to the 0.81.2 milestone Oct 29, 2018
@balloob balloob merged commit b03e605 into home-assistant:dev Oct 29, 2018
@ghost ghost removed the in progress label Oct 29, 2018
balloob pushed a commit that referenced this pull request Oct 29, 2018
@balloob balloob mentioned this pull request Oct 29, 2018
@Kane610 Kane610 deleted the unifi-fix-retry-functionality branch October 29, 2018 21:47
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants