New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass hass_config to load_platform #17952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 7, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 7, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 7, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
* Pass hass_config to load_platform * Fix tests * Lint
- Pass hass_config to load_platform (@balloob - home-assistant#17952)
Why on earth is this not under the list of breaking changes? It clearly breaks almost all custom components. |
Then almost all custom components were breaking Home Assistant 🙈 But seriously, you're the first to complain about this. So I don't think your assumption that it breaks all is right. A PR to add this to the breaking changes in the release notes is welcome. |
Well, its an API change of a well used method. Not sure how this is handled with HA tho. This should in my opinion be a major version bump since it is not backward compatible and breaks "many" plugins, even plugins in HA core. |
Description:
Follow up on #17942
Fixes #17935
Found a lot more. Made the parameters mandatory and also added a safety assert in case people just add
{}
.Checklist:
tox
. Your PR cannot be merged unless tests passIf the code does not interact with devices: