Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update georss_client to 0.4 #18090

Closed

Conversation

exxamalte
Copy link
Contributor

@exxamalte exxamalte commented Nov 1, 2018

Description:

Update georss_client to version 0.4 which loosens its own third-party dependencies, trying not to interfere with Home Assistant's own dependencies.

Related issue (if applicable): n/a

Pull request in home-assistant.io with documentation (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@fabaff
Copy link
Member

fabaff commented Nov 1, 2018

You can push updates to the same branch. Add an additional commit then it would be part of #18088.

@exxamalte
Copy link
Contributor Author

Sure, no problem. I've merged the two PRs now, and will close this one.

@exxamalte exxamalte closed this Nov 1, 2018
@ghost ghost removed the in progress label Nov 1, 2018
@exxamalte exxamalte deleted the georss-client-library-update branch November 2, 2018 10:04
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants