Add support for sensors from Flu Near You #18136
Conversation
ghost
added
the
| ATTR_ZIP_CODE = 'zip_code' | ||
|
|
||
| DEFAULT_ATTRIBUTION = 'Data provided by Flu Near You' | ||
| DEFAULT_SCAN_INTERVAL = timedelta(minutes=30) |
There was a problem hiding this comment.
This makes your sensors update every 30 seconds (the sensor default) but new data will only be available every 30 minutes.
Consider naming this MIN_TIME_BETWEEN_UPDATES instead and lower it a bit.
Then set SCAN_INTERVAL to 30 minutes so Home Assistant actually only updates the sensor every 30 minutes.
| client = await create_client(latitude, longitude, websession) | ||
| except FluNearYouError as err: | ||
| _LOGGER.error('There was an error while setting up: %s', err) | ||
| return False |
There was a problem hiding this comment.
If you expect that it might work later (like when the network is back), you can raise PlatformNotReady.
There was a problem hiding this comment.
☝️ or just return. Nothing is checking this return value.
| client = await create_client(latitude, longitude, websession) | ||
| except FluNearYouError as err: | ||
| _LOGGER.error('There was an error while setting up: %s', err) | ||
| return False |
There was a problem hiding this comment.
☝️ or just return. Nothing is checking this return value.
| if self._category == CATEGORY_CDC_REPORT: | ||
| data = self.fny.data[CATEGORY_CDC_REPORT] | ||
| self._attrs.update({ | ||
| ATTR_REPORTED_DATE: data['week_date'], |
There was a problem hiding this comment.
There will be a KeyError here if the data update errors.
| elif self._category == CATEGORY_USER_REPORT: | ||
| data = self.fny.data[CATEGORY_USER_REPORT] | ||
| self._attrs.update({ | ||
| ATTR_CITY: data['city'].split('(')[0], |
| TYPE_USER_CHICK, TYPE_USER_DENGUE, TYPE_USER_FLU, | ||
| TYPE_USER_LEPTO, TYPE_USER_SYMPTOMS)) | ||
| else: | ||
| self._state = data[self._kind] |
|
Thanks, @amelchio and @MartinHjelmare! 😄 |
|
Can be merged when build passes. |
Description:
This PR adds support for sensors from Flu Near You:
Related issue (if applicable): N/A
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7345
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.