Elk-M1 fixes #18154
Merged
Elk-M1 fixes #18154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: elkm1
small-pr
ghost
added
the
MartinHjelmare
approved these changes
Nov 5, 2018
| vol.Optional(CONF_TASK): CONFIG_SCHEMA_SUBDOMAIN, | ||
| vol.Optional(CONF_THERMOSTAT): CONFIG_SCHEMA_SUBDOMAIN, | ||
| vol.Optional(CONF_ZONE): CONFIG_SCHEMA_SUBDOMAIN, | ||
| vol.Optional(CONF_AREA, default={CONF_ENABLED: True}): |
There was a problem hiding this comment.
An empty dict would also work as default value, since the default value is passed to the CONFIG_SCHEMA_SUBDOMAIN where the defaults of the dict are populated.
There was a problem hiding this comment.
Thank you! I made the change you suggested.
MartinHjelmare
approved these changes
Nov 5, 2018
|
Can be merged when build passes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes two problems that were found on the newly released Elk-M1 code in 0.81. Both are setting defaults in voluptuous. Both are minor fixes. No documentation changes required.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: