Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure MQTT fan component if discovery info is changed #18177

Merged
merged 1 commit into from Nov 27, 2018

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Nov 4, 2018

Description:

Reconfigure MQTT light component if discovery info is changed.
This PR is an extension of #18169 which introduced support for reconfiguring MQTT binary sensors.

(This is bullet 2 in home-assistant/architecture#70)

PRs for other platforms will be opened separately.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • Tests have been added to verify that the new code works.

@emontnemery emontnemery requested a review from a team as a code owner November 4, 2018 00:29
@ghost ghost added the in progress label Nov 4, 2018
@emontnemery emontnemery changed the title Recreate fan component if discovery info is changed WIP - Recreate fan component if discovery info is changed Nov 4, 2018
@ghost ghost assigned emontnemery Nov 20, 2018
@emontnemery emontnemery changed the title WIP - Recreate fan component if discovery info is changed Reconfigure MQTT fan component if discovery info is changed Nov 20, 2018
@emontnemery
Copy link
Contributor Author

@OttoWinter, @balloob This one is a follow-up to #18169 as well, do you think it's OK?

@balloob balloob merged commit 4a4ed12 into home-assistant:dev Nov 27, 2018
@ghost ghost removed the in progress label Nov 27, 2018
@emontnemery emontnemery deleted the mqtt_discovery_update_fan branch December 2, 2018 16:29
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants