Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tibber login validate #18235

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Tibber login validate #18235

merged 2 commits into from
Nov 5, 2018

Conversation

Danielhiversen
Copy link
Member

Description:

Tibber login validate

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost assigned Danielhiversen Nov 5, 2018
@ghost ghost added the in progress label Nov 5, 2018
@amelchio amelchio merged commit 3366d2c into dev Nov 5, 2018
@ghost ghost removed the in progress label Nov 5, 2018
@Danielhiversen Danielhiversen deleted the tibber_login_validate branch November 9, 2018 15:03
@balloob balloob mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amelchio amelchio amelchio approved these changes

Assignees

@Danielhiversen Danielhiversen

Labels
cla-signed integration: tibber small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Danielhiversen @amelchio @homeassistant