-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new launch sensor to keep track of space launches. #18274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should throttle the sensor by default. Maybe something like 10 or 15 min. The data is pretty static and there seems to be no need to poll with the default interval.
I will add that @fabaff and also make the package reuse the aiohttp session from homeassistant as mentioned here: #18237 (comment) |
10 or 15 minutes? What about 24 hours? This is very static info… |
Some days have multiple launches, my plan was to set it to 1-hour intervals |
I guess the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some style things.
…ry_code, remove CONF_ from ATTRIBUTION.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to fly!
Soo, would people agree that this name is a bit too generic ? |
I would think that launch_library would be a better name, as it reflects the name of the service. |
@balloob I do not disagree with that do you want me to make a PR to change it? |
Yes let's do it to before it is released |
I'll start that now :) |
I would like to build a countdown sensor and it would be very useful if this launch sensor had an attribute based on the "wsstamp" field. IE the unix formatted window start time. |
@HemiBob Please don't use closed/merged pull requests for seeking help/support/feature requests. For the right place see: https://www.home-assistant.io/help |
Description:
Adda a new sensor to show the next upcoming space launch 🚀
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7397
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.