Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumping asuswrt #18427

Merged
merged 1 commit into from Nov 13, 2018
Merged

bumping asuswrt #18427

merged 1 commit into from Nov 13, 2018

Conversation

kennedyshead
Copy link
Contributor

@kennedyshead kennedyshead commented Nov 13, 2018 •
edited

Description:

  1. Some devices do not have $PATH set correctly
  2. There are never devices that do not have wl, therefor we use wlanconfig on these devices
  3. Added support for guest networks
  4. Reworked some upload/download logic

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@ghost ghost added the in progress label Nov 13, 2018
@kennedyshead kennedyshead changed the title Taking care of some nasty bugs bumping asuswrt Nov 13, 2018
fabaff
fabaff approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit ebdfb56 into home-assistant:dev Nov 13, 2018
@ghost ghost removed the in progress label Nov 13, 2018
This was referenced Nov 15, 2018
Closed
Closed
Closed
@balloob balloob mentioned this pull request Nov 29, 2018
Merged
@kennedyshead kennedyshead deleted the bumping_asuswrt branch January 25, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
cla-signed integration: asuswrt small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kennedyshead @fabaff @homeassistant @MagnusKnutas