Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove self from update function in rainmachine #18807

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Remove self from update function in rainmachine #18807

merged 1 commit into from
Nov 29, 2018

Conversation

Danielhiversen
Copy link
Member

Description:

Untested

Related issue (if applicable): fixes #18805

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost assigned Danielhiversen Nov 29, 2018
@ghost ghost added the in progress label Nov 29, 2018
@Danielhiversen Danielhiversen mentioned this pull request Nov 29, 2018
Closed
bachya
bachya approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you. Good to merge when build passes. Should go out in 0.83.1

@bachya bachya added this to the 0.83.1 milestone Nov 29, 2018
@balloob balloob merged commit 4bc9e6d into dev Nov 29, 2018
@delete-merged-branch delete-merged-branch bot deleted the rainmachine branch November 29, 2018 21:28
@ghost ghost removed the in progress label Nov 29, 2018
@bachya bachya mentioned this pull request Nov 29, 2018
Merged
9 tasks
balloob pushed a commit that referenced this pull request Nov 29, 2018
@Danielhiversen @balloob
Remove self from update function in rainmachine (#18807)
d9124b1
@balloob balloob mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachya bachya bachya approved these changes

Assignees

@Danielhiversen Danielhiversen

Labels
cherry-picked cla-signed integration: rainmachine small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.83.1
Development

Successfully merging this pull request may close these issues.

RainMachine traces: TypeError: update() missing 1 required positional argument: 'self'
4 participants
@Danielhiversen @bachya @balloob @homeassistant