-
-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensor platform for SolarEdge Monitoring API #18846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a python pip packages for you API
@pvizeli Thanks, should be fixed |
Added async_update to sensor class Added Throttle to SolarEdge data update Added CONF_NAME to platform settings Added credentials check for api Minor code style changes
HI, great to see this is being developed. Please allow me to ask while you're still at it, if you will also be adding the Inventory sensor, next to the planned Overview sensors:
maybe even consider site-details and equipment-list? |
Hi @Mariusthvdb, Thanks, nice suggestion, I will look into it. For the site details I could add an additional sensor which will be updated once a day (SolarEdge has a daily query limit of 300 requests). Details such as site id, name, status, peak power, etc. could then be added as attributes to a sensor (e.g. solaredge_site_details). For the inventory, I might be able to separate this per equipment type (e.g. meters, sensors, gateways, etc). This might however be a bit more difficult as these are lists. If you have any suggestions, let me know. |
Updated platform setup
Correct import for PLATFORM_SCHEMA
Correct return statements Remove initial update call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can be merged when build passes.
Thanks @MartinHjelmare, I've also been looking at the suggestions of @Mariusthvdb and have some ideas on how to integrate these sensors as well. Will add them in a later update of the platform. |
* Adding sensor for SolarEdge Monitoring API support * Adding support for Rova garbage calendar * Update solaredge to pass lint and flake8 * Added solaredge.py to .coveragerc * Added extend for Voluptuous schema * Fixed styling issues * Removed rova.py for later feature * Replaced API requests with python pip package * Fixed styling issues * Updated to new async syntax Added async_update to sensor class Added Throttle to SolarEdge data update Added CONF_NAME to platform settings Added credentials check for api Minor code style changes * Remove unnecessary debug logging * Updated dict keys * Added SCAN_INTERVAL Updated platform setup * Remove DOMAIN variable Correct import for PLATFORM_SCHEMA * Change some debug to error messages Correct return statements Remove initial update call * Fix pylint and flake8 errors
Description:
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7735
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: