Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Yale Smart Alarm platform to new Yale API #18990

Conversation

domwillcode
Copy link
Contributor

Description:

Update Yale Smart Alarm platform to use Yale's new API which replaces the deprecated version.
Interface is unchanged. Bumped yalesmartalarmclient to v0.1.5.

See: https://github.com/domwillcode/yale-smart-alarm-client/tree/v0.1.5

Related issue (if applicable): fixes #17396
#17396

Checklist:

  • [ x ] The code change is tested and works locally.
  • [ x ] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ x ] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ x ] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • [ x ] New dependencies are only imported inside functions that use them ([example][ex-import]).
  • [ x ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [ N/A ] New files were added to .coveragerc.

If the code does not interact with devices:

  • [ N/A ] Tests have been added to verify that the new code works.

@laf
Copy link
Contributor

laf commented Dec 4, 2018

For what it's worth, I'm running this live at the moment and it works fine for me.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yale Smart Alarm integration unresponsive
4 participants