Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring of MQTT switch #19010

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Small refactoring of MQTT switch #19010

merged 1 commit into from
Dec 5, 2018

Conversation

emontnemery
Copy link
Contributor

Description:

Small refactoring of MQTT switch as proposed in #18174:

  • Just store config instead of every variable since the configuration values are just copied.

(Follow-up to #18674)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost assigned emontnemery Dec 4, 2018
@ghost ghost added the in progress label Dec 4, 2018
@balloob balloob merged commit 578a2cf into home-assistant:dev Dec 5, 2018
@ghost ghost removed the in progress label Dec 5, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
@tari tari mentioned this pull request Dec 19, 2018
Closed
@emontnemery emontnemery deleted the mqtt_switch_refactor branch December 19, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emontnemery emontnemery

Labels
integration: mqtt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emontnemery @balloob @homeassistant