Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of elkm1_lib #19030

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Bump version of elkm1_lib #19030

merged 1 commit into from
Dec 5, 2018

Conversation

gwww
Copy link
Contributor

@gwww gwww commented Dec 5, 2018

Description:

Bump base library (elkm1_lib) version.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Dec 5, 2018
@gwww
Copy link
Contributor Author

gwww commented Dec 5, 2018

Not sure why the pylint build is failing. I can't tell from the terminal log. It doesn't appear to be my change. Anything I should do?

@cgarwood
Copy link
Member

cgarwood commented Dec 5, 2018

They fail sometimes on a good day for no reason, and there's been a couple flaky tests causing extra failures lately. I restarted the job so hopefully it will complete this time 😃

@cgarwood cgarwood merged commit b31c524 into home-assistant:dev Dec 5, 2018
@ghost ghost removed the in progress label Dec 5, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants