-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow emulated hue to set climate component temperature #19034
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
in progress
label
Dec 5, 2018
houndci-bot
reviewed
Dec 5, 2018
fabaff
changed the title
allow emulated hue to set climate component temperature
Allow emulated hue to set climate component temperature
Dec 5, 2018
amelchio
reviewed
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can fix the conflicts that have emerged, I think this is good.
chilicheech
requested review from
andrewsayre,
bachya,
Danielhiversen,
frenck,
rytilahti,
syssi and
a team
as code owners
March 7, 2019 17:18
houndci-bot
reviewed
Mar 7, 2019
houndci-bot
reviewed
Mar 7, 2019
@amelchio merge conflicts fixed 😄 |
amelchio
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This enables the emulated_hue component to set the temperature of climate devices.
The goal here is not to have the thermostat show up as a thermostat in Alexa, because with emulated hue it will show up as a light. The goal is simply to be able to say “Alexa, set the heater to 66” and have it set the thermostat temperature in that way. Things like “Alexa, raise the temperature” or “Alexa, I’m cold” or “Alexa, turn on the heater” won’t work. Only specifically setting the temperature will work.
This change makes it do the same thing it does for setting media player volume. The emulated_hue will “pretend” the thermostat is a light and use the brightness level as the temperature for the thermostat. This is the same thing it already does to media players. It uses the brightness level as the volume level.
Related issue (if applicable): This implements the feature requested here: https://community.home-assistant.io/t/emulated-hue-should-support-climate-thermostats/82702
Pull request in home-assistant.io with documentation (if applicable): There doesn't seem to be any home-assistant.io changes needed.
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: