Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade slacker to 0.12.0 #19142

Merged
merged 1 commit into from
Dec 9, 2018
Merged

Upgrade slacker to 0.12.0 #19142

merged 1 commit into from
Dec 9, 2018

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 9, 2018

Description:

Commit log: https://github.com/os/slacker/commits/master

Example entry for configuration.yaml (if applicable):

notify:
  - name : slack
    platform: slack
    api_key: !secret slack_api
    default_channel: '#ha'

Tested with the following content for Service data:

{"message": "The sun is {% if is_state('sun.sun', 'above_horizon') %}up{% else %}down{% endif %}!"}

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned fabaff Dec 9, 2018
@ghost ghost added the in progress label Dec 9, 2018
@fabaff fabaff merged commit 527f9cd into dev Dec 9, 2018
@delete-merged-branch delete-merged-branch bot deleted the upgrade-slacker branch December 9, 2018 22:23
@ghost ghost removed the in progress label Dec 9, 2018
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants