Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON attribute topic to MQTT sensor #19223

Merged

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Dec 12, 2018

Description:

Add JSON attribute topic to MQTT sensor in same way as supported by MQTT binary sensor (#18923).

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#TODO

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - docs are missing

@fabaff
Copy link
Member

fabaff commented Dec 15, 2018

@emontnemery, can you please squash when you are merging?

@emontnemery
Copy link
Contributor Author

Yes, sorry about that! Should I revert and merge again?

@fabaff
Copy link
Member

fabaff commented Dec 15, 2018

No, just for the future. The release helper script is getting the data from the commit history.

"Squash and merge" is unfortunately not the default.

@emontnemery emontnemery deleted the mqtt_sensor_json_attributes_topic branch December 19, 2018 18:59
@Fonta
Copy link

Fonta commented Jan 6, 2019

The deprecated warning might need some clarification in the docs.
I've updated to 0.85.0b0 yesterday and now I'm getting 4 of these warnings while I'm not using "json_attributes".

@emontnemery
Copy link
Contributor Author

@f0nt4 There shouldn't be a warning if you're not using json_attributes, can you please open a new issue for that?

@Fonta
Copy link

Fonta commented Jan 6, 2019

There we're some retained topics from testing a script to automatically create notifications for low batteries. I'm not using the script anymoer so I've cleared the topics and the warnings are now gone.

https://github.com/notoriousbdg/Home-AssistantConfig/blob/master/packages/battery_alert.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants