-
-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON attribute topic to MQTT sensor #19223
Add JSON attribute topic to MQTT sensor #19223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - docs are missing
@emontnemery, can you please squash when you are merging? |
Yes, sorry about that! Should I revert and merge again? |
No, just for the future. The release helper script is getting the data from the commit history. "Squash and merge" is unfortunately not the default. |
The deprecated warning might need some clarification in the docs. |
@f0nt4 There shouldn't be a warning if you're not using |
There we're some retained topics from testing a script to automatically create notifications for low batteries. I'm not using the script anymoer so I've cleared the topics and the warnings are now gone. https://github.com/notoriousbdg/Home-AssistantConfig/blob/master/packages/battery_alert.yaml |
Description:
Add JSON attribute topic to MQTT sensor in same way as supported by MQTT binary sensor (#18923).
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#TODO
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: