Fix restore state for manual alarm control panel #19284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: alarm_control_panel.manual
small-pr
balloob
approved these changes
Dec 14, 2018
balloob
pushed a commit
that referenced
this pull request
Dec 17, 2018
* Fixed manual alarm control panel restore state * Revert "Fixed manual alarm control panel restore state" This reverts commit 61c9faf. * Fixed manual alarm control panel's state restore
Merged
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
* Fixed manual alarm control panel restore state * Revert "Fixed manual alarm control panel restore state" This reverts commit 61c9faf. * Fixed manual alarm control panel's state restore
ghost
added
integration: manual
and removed
platform: alarm_control_panel.manual
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A bug in the new state restoring mechanism introduced in version 0.84 broke the manual alarm control panel's ability to restore. This small change fixes this and also another related issue whereby restoring the alarm state while its in "Pending" state causes the component to be stuck in that state indefinitely.
Related issue (if applicable): No open issues
Pull request in home-assistant.io with documentation (if applicable): N/A
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: