Upgrade requests to 2.21.0 #19385
Merged
Upgrade requests to 2.21.0 #19385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Dec 17, 2018
setup.py
Outdated
| @@ -38,8 +38,8 @@ | |||
| 'attrs==18.2.0', | |||
| 'bcrypt==3.1.4', | |||
| 'certifi>=2018.04.16', | |||
| # Dec 5, 2018: Idna released 2.8, requests caps idna at <2.8, CI fails | |||
| 'idna==2.7', | |||
| # Dec 17, 2018: Idna released 2.8, requests 2.21.0 is pinning idna | |||
There was a problem hiding this comment.
If requests can work with the newer idna, we should remove our pinning completely.
There was a problem hiding this comment.
requests wants 'idna>=2.5,<2.9'.
There was a problem hiding this comment.
So shall we drop our pinning then ? We only added it because the newer requests could not work with it but it somehow got installed.
There was a problem hiding this comment.
Ok, let's remove it. In a worst case scenario we would need to add it again.
fabaff
force-pushed
the
upgrade-requests
branch
from
c260689
to
686a856
Compare
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changelog: https://github.com/requests/requests/blob/master/HISTORY.md#2210-2018-12-10
Checklist:
tox. Your PR cannot be merged unless tests pass